Re: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h

[Michael Ellerman]

Michal Suchanek <msuchanek@xxxxxxx> writes:

> Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings") uses u64 in asm/hvcall.h without including linux/types.h
>
> This breaks hvcall.h users that do not include the header themselves.
>
> Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
>     settings")
>
> Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> ---
>  arch/powerpc/include/asm/hvcall.h | 1 +
>  1 file changed, 1 insertion(+)

Thanks. None of my ~250 defconfig test builds hit this, what config are
you using?

cheers

> diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
> index f0461618bf7b..eca3f9c68907 100644
> --- a/arch/powerpc/include/asm/hvcall.h
> +++ b/arch/powerpc/include/asm/hvcall.h
> @@ -353,6 +353,7 @@
>  #define PROC_TABLE_GTSE		0x01
>  
>  #ifndef __ASSEMBLY__
> +#include <linux/types.h>
>  
>  /**
>   * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
> -- 
> 2.13.6