Re: [PATCH 1/2] objtool: Fix seg fault with gold linker

[Ingo Molnar]

* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> On Tue, Jan 16, 2018 at 01:21:44AM +0100, Ingo Molnar wrote:
> > 
> > * Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > 
> > > Objtool seg faults when the gold linker is used with
> > > CONFIG_MODVERSIONS=y and CONFIG_UNWINDER_ORC=y.
> > > 
> > > With CONFIG_MODVERSIONS=y, the .o file gets passed to the linker before
> > > being passed to objtool.  The gold linker seems to strip unused ELF
> > > symbols by default, which confuses objtool and causes the seg fault when
> > > it's trying to generate ORC metadata.
> > 
> > BTW., if it's still unfixed, could we fix that segfault as well, and turn it into 
> > a more useful failure message?
> 
> Good point.  I'll fix up this seg fault, and the other one
> found/introduced when adding retpoline support.

Thanks!

	Ingo