Re: [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI_WATCHDOG=y

[Adam Ford]

On Mon, Jan 15, 2018 at 11:59 PM, Sekhar Nori <nsekhar@xxxxxx> wrote:
> On Monday 15 January 2018 10:59 PM, David Lechner wrote:
>> This changes CONFIG_DAVINCI_WATCHDOG from a module to a compiled-in
>> option. Since the reset function has been moved out of the mach code in
>> commit 0808d3260456 ("ARM: davinci: remove watchdog reset") and into the
>> watchdog driver, devices cannot reboot unless the watchdog driver is
>> loaded, so make it a compiled-in option so that we can always reboot, even
>> when modules are not loaded.
>>
>> Cc: Sekhar Nori <nsekhar@xxxxxx>
>> Suggested-by: Adam Ford <aford173@xxxxxxxxx>
>> Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
>
> Hmm, we already depend on modules to load correctly for a lot of
> functionality. Why should reboot be an exception? In general, unless the
> driver is needed for loading rootfile system, I would keep it as a module.

I would argue that his patch corrects a regression introduced by the
patch series.  Before the series, 'reboot' worked properly without the
watchdog being loaded as a module.  With this patch series 'reboot'
stops functioning which I would argue is a regression.  Making the
watchdog part of the kernel fixes the broken reboot regression.  I
would request it be accepted.

>
> Thanks,
> Sekhar

adam