Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

From: Adam Ford
Date: Tue Jan 16 2018 - 07:21:30 EST


On Tue, Jan 16, 2018 at 5:22 AM, Sekhar Nori <nsekhar@xxxxxx> wrote:
> Hi Adam, David,
>
> On Friday 12 January 2018 03:04 AM, Adam Ford wrote:
>> Thanks for clarifying. I was able to make it work with the following patch:
>>
>> diff --git a/drivers/clk/davinci/psc-da850.c b/drivers/clk/davinci/psc-da850.c
>> index 3b4583d..a76b8682 100644
>> --- a/drivers/clk/davinci/psc-da850.c
>> +++ b/drivers/clk/davinci/psc-da850.c
>> @@ -25,7 +25,7 @@ static const struct davinci_psc_clk_info
>> da850_psc0_info[] __initconst = {
>> LPSC(9, 0, uart0, pll0_sysclk2, 0),
>> LPSC(13, 0, pruss, pll0_sysclk2, 0),
>> LPSC(14, 0, arm, pll0_sysclk6, LPSC_ALWAYS_ENABLED),
>> - LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET),
>> + LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET |
>> LPSC_ALWAYS_ENABLED),
>
> Keeping the DSP clock always enabled was not needed earlier AFAICS, so
> this needs to be investigated.

I was testing the DA850-evm and found it was required or the DA850
wouldn't boot. I don't know enough of why to explain it. I went
through all the clocks as suggested by David, and this one-line patch
fixed the hanging problem I had. Without it the AM1808 board I have
won't boot.

adam
>
> Thanks,
> Sekhar