Re: [PATCH 1/2] nvme: add tracepoint for nvme_setup_cmd

[Johannes Thumshirn]

On Tue, Jan 16, 2018 at 12:27:33PM +0100, Hannes Reinecke wrote:
> In general I'd rather have the tracepoints when actually submitting the
> request; with this tracepoint we might be getting a trace which doesn't
> really indicate if the command was submitted at all.

yes but if we really want to be 100% certain we need to take the tracepoints
in either in blk_mq_dispatch_rq_list() and trace the return value of the respective
->queue_rq() or in the PCI/FC/RDMA drivers.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850