Re: [PATCH] crypto: mxs-dcp: Add empty hash export and import

[Marek Vasut]

On 01/16/2018 05:16 PM, Kamil Konieczny wrote:
> Crypto framework will require async hash export/import, so add empty
> functions to prevent OOPS.

Shouldn't this be handled on the subsystem level with some

if (foo->bar)
 foo->bar();

instead?

> Signed-off-by: Kamil Konieczny <k.konieczny@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/crypto/mxs-dcp.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c
> index 764be3e6933c..a10c418d4e5c 100644
> --- a/drivers/crypto/mxs-dcp.c
> +++ b/drivers/crypto/mxs-dcp.c
> @@ -759,6 +759,16 @@ static int dcp_sha_digest(struct ahash_request *req)
>  	return dcp_sha_finup(req);
>  }
>  
> +static int dcp_sha_noimport(struct ahash_request *req, const void *in)
> +{
> +	return -ENOSYS;
> +}
> +
> +static int dcp_sha_noexport(struct ahash_request *req, void *out)
> +{
> +	return -ENOSYS;
> +}
> +
>  static int dcp_sha_cra_init(struct crypto_tfm *tfm)
>  {
>  	crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm),
> @@ -829,6 +839,8 @@ static struct ahash_alg dcp_sha1_alg = {
>  	.final	= dcp_sha_final,
>  	.finup	= dcp_sha_finup,
>  	.digest	= dcp_sha_digest,
> +	.import = dcp_sha_noimport,
> +	.export = dcp_sha_noexport,
>  	.halg	= {
>  		.digestsize	= SHA1_DIGEST_SIZE,
>  		.base		= {
> @@ -853,6 +865,8 @@ static struct ahash_alg dcp_sha256_alg = {
>  	.final	= dcp_sha_final,
>  	.finup	= dcp_sha_finup,
>  	.digest	= dcp_sha_digest,
> +	.import = dcp_sha_noimport,
> +	.export = dcp_sha_noexport,
>  	.halg	= {
>  		.digestsize	= SHA256_DIGEST_SIZE,
>  		.base		= {
> 


-- 
Best regards,
Marek Vasut