Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst format

From: Greg KH
Date: Tue Jan 16 2018 - 11:54:48 EST


On Tue, Jan 16, 2018 at 03:40:18PM +0000, Ruxandra Ioana Ciocoi Radulescu wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> > Sent: Tuesday, January 16, 2018 5:14 PM
> > To: Bogdan Purcareata <bogdan.purcareata@xxxxxxx>
> > Cc: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>; Ruxandra Ioana Ciocoi
> > Radulescu <ruxandra.radulescu@xxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxx;
> > robh@xxxxxxxxxx; stuyoder@xxxxxxxxx; arnd@xxxxxxxx;
> > marc.zyngier@xxxxxxx; Roy Pledge <roy.pledge@xxxxxxx>; Ioana Ciornei
> > <ioana.ciornei@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Horia GeantÄ
> > <horia.geanta@xxxxxxx>; Nipun Gupta <nipun.gupta@xxxxxxx>;
> > tglx@xxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > jason@xxxxxxxxxxxxxx
> > Subject: Re: [PATCH 8/8] staging: fsl-mc: Convert documentation to rst
> > format
> >
> > On Tue, Jan 16, 2018 at 03:19:10PM +0200, Bogdan Purcareata wrote:
> > > From: Ioana Radulescu <ruxandra.radulescu@xxxxxxx>
> > >
> > > Update the doc file to comply with the rst format.
> > >
> > > It's not integrated into the documentation build structure yet,
> > > since it's still located in drivers/staging.
> > >
> > > Signed-off-by: Ioana Radulescu <ruxandra.radulescu@xxxxxxx>
> > > Reviewed-by: Laurentiu Tudor <laurentiu.tudor@xxxxxxx>
> > > ---
> > > drivers/staging/fsl-mc/README.txt | 387 ----------------------------------
> > > drivers/staging/fsl-mc/overview.rst | 404
> > ++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 404 insertions(+), 387 deletions(-)
> > > delete mode 100644 drivers/staging/fsl-mc/README.txt
> > > create mode 100644 drivers/staging/fsl-mc/overview.rst
> >
> > Please generate patches with the -M option to git format-patch, so we
> > can see the file move, not just get removed and added as a brand new
> > one.
>
> Sure, I can do this.
>
> Even with -M, the diff is rather large since the indenting changes for most
> of the lines in the file. Would it be better to make two patches, with
> the first changing just line indenting and the second one, where the file is
> moved, only updating rst specific markups?

Nah, just use -M and we can take it from there.

thanks,

greg k-h