Re: [PATCH] bnxt_en: don't update cpr->rx_bytes with uninitialized length len

From: Michael Chan
Date: Tue Jan 16 2018 - 12:06:09 EST


On Tue, Jan 16, 2018 at 2:22 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently in the cases where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP or
> CMP_TYPE_RX_L2_TPA_END_CMP the exit path updates cpr->rx_bytes with an
> uninitialized length len. Fix this by adding a new exit path that does
> not update the cpr stats with the bogus length len and remove the unused
> label next_rx_no_prod.
>
> Detected by CoverityScan, CID#1463807 ("Uninitialized scalar variable")
> Fixes: 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks.

Acked-by: Michael Chan <michael.chan@xxxxxxxxxxxx>