Re: [PATCH] ACPI/PCI: pci_link: reduce verbosity when IRQ is enabled

[Bjorn Helgaas]

On Tue, Jan 16, 2018 at 01:53:00PM -0500, Sinan Kaya wrote:
> Correcting linux-pci email.
> 
> On 1/16/2018 1:51 PM, Sinan Kaya wrote:
> > When ACPI Link object is enabled, the message is printed with a warning
> > prefix. Some test tools are capturing warning and test error types as
> > errors. Let's reduce the verbosity of success case.
> > 
> > Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx>

Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

Looks like this was a result of 4d9391557b68 ("ACPI: add missing KERN_*
constants to printks"), which I think added the wrong level in this case.

> > ---
> >  drivers/acpi/pci_link.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
> > index bc3d914..85ad679 100644
> > --- a/drivers/acpi/pci_link.c
> > +++ b/drivers/acpi/pci_link.c
> > @@ -612,7 +612,7 @@ static int acpi_pci_link_allocate(struct acpi_pci_link *link)
> >  			acpi_isa_irq_penalty[link->irq.active] +=
> >  				PIRQ_PENALTY_PCI_USING;
> >  
> > -		printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n",
> > +		pr_info("%s [%s] enabled at IRQ %d\n",
> >  		       acpi_device_name(link->device),
> >  		       acpi_device_bid(link->device), link->irq.active);
> >  	}
> > 
> 
> 
> -- 
> Sinan Kaya
> Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
> Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html