Re: [PATCH RFC tip/core/rcu] Make SRCU be once again optional
From: Paul E. McKenney
Date: Tue Jan 16 2018 - 18:57:04 EST
On Wed, Jan 17, 2018 at 12:03:18AM +0100, Arnd Bergmann wrote:
> On Tue, Jan 16, 2018 at 11:55 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> >
> > That fixed the first warning for me, doing the same thing for all three
> > fixed the rest
>
> Now with my workaround applied and the original randconfig that triggered
> the failure, I get another problem:
>
> drivers/base/power/wakeup.c:68:1: error: data definition has no type
> or storage class [-Werror]
> DEFINE_STATIC_SRCU(wakeup_srcu);
>
> Evidently there is at least one driver that uses SRCU but doesn't 'select SRCU'
> in Kconfig. There are probably others that just haven't been found.
Does adding "select SRCU" on "config PM_SLEEP" in kernel/power/Kconfig
fix this?
Thanx, Paul