Re: [PATCH] sparse doesn't support struct randomization

[Kees Cook]

On Tue, Jan 16, 2018 at 6:45 PM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>
> Without this patch, I drown in a sea of unknown attribute warnings
>
> Signed-off-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>

Thanks!

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

Andrew, are you able to take this? I have no other gcc-plugin changes
pending for the coming merge window...

-Kees

> ---
>  include/linux/compiler-gcc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
> index 2272ded07496..631354acfa72 100644
> --- a/include/linux/compiler-gcc.h
> +++ b/include/linux/compiler-gcc.h
> @@ -219,7 +219,7 @@
>  /* Mark a function definition as prohibited from being cloned. */
>  #define __noclone      __attribute__((__noclone__, __optimize__("no-tracer")))
>
> -#ifdef RANDSTRUCT_PLUGIN
> +#if defined(RANDSTRUCT_PLUGIN) && !defined(__CHECKER__)
>  #define __randomize_layout __attribute__((randomize_layout))
>  #define __no_randomize_layout __attribute__((no_randomize_layout))
>  #endif
> --
> 2.15.1
>



-- 
Kees Cook
Pixel Security