Re: [PATCH 1/3] powerpc/32: Fix hugepage allocation on 8xx at hint address

[Aneesh Kumar K.V]

Christophe LEROY <christophe.leroy@xxxxxx> writes:

>>
>>> How should I split in separate patches ? Something like ?
>>> 1/ Slice support for PPC32 > 2/ Activate slice for 8xx
>> 
>> Yes something like that. Will you be able to avoid that
>>  Âif (SLICE_NUM_HIGH) from the code? That makes the code ugly. Right now 
>> i don't have definite suggestion on what we could do though.
>> 
>
> Could use #ifdefs instead, but in my mind it would be even more ugly.
>
> I would have liked just doing nothing, but the issue is that at the 
> moment bitmap_xxx() functions are not prepared to handle bitmaps of size 
> zero. Should we try to change that ? Any chance to succeed ?
>

How much code duplication it is to do slice_32.c?

Michael,

What do you suggest here?

-aneesh