Re: [PATCH] Documentation: Fix misconversion of #if

From: Mauro Carvalho Chehab
Date: Wed Jan 17 2018 - 06:05:01 EST


Em Tue, 16 Jan 2018 19:40:55 -0800
Matthew Wilcox <willy@xxxxxxxxxxxxx> escreveu:

> From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>
> At some stage of the conversion pipeline, something thought that the
> DocBook entity &num; should be rendered as NUM instead of #.
>
> Signed-off-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
Reviewed-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
> ---
> Documentation/kernel-hacking/hacking.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kernel-hacking/hacking.rst b/Documentation/kernel-hacking/hacking.rst
> index daf3883b2694..5c4d30e81b7f 100644
> --- a/Documentation/kernel-hacking/hacking.rst
> +++ b/Documentation/kernel-hacking/hacking.rst
> @@ -690,8 +690,8 @@ not provide the necessary runtime environment and the include files are
> not tested for it. It is still possible, but not recommended. If you
> really want to do this, forget about exceptions at least.
>
> -NUMif
> ------
> +#if
> +---
>
> It is generally considered cleaner to use macros in header files (or at
> the top of .c files) to abstract away functions rather than using \`#if'



Thanks,
Mauro