Re: [PATCH] iommu/omap: Fix debugfs_create_*() usage

From: Joerg Roedel
Date: Wed Jan 17 2018 - 08:23:59 EST


On Tue, Jan 02, 2018 at 04:29:45PM +0100, Geert Uytterhoeven wrote:
> When exposing data access through debugfs, the correct
> debugfs_create_*() functions must be used, depending on data type.
>
> Remove all casts from data pointers passed to debugfs_create_*()
> functions, as such casts prevent the compiler from flagging bugs.
>
> omap_iommu.nr_tlb_entries is "int", hence casting to "u8 *" exposes only
> a part of it. Fix this by using debugfs_create_u32() instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Compile-tested only.
> ---
> drivers/iommu/omap-iommu-debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.