Re: [PATCH] IIO: ADC: stm32-dfsdm: remove unused variable

From: Robin Murphy
Date: Wed Jan 17 2018 - 10:27:40 EST


On 17/01/18 14:46, Arnd Bergmann wrote:
A cleanup left one variable behind that is no longer needed and
can be removed, as shown by the gcc warning:

drivers/iio/adc/stm32-dfsdm-core.c: In function 'stm32_dfsdm_probe':
drivers/iio/adc/stm32-dfsdm-core.c:245:29: error: unused variable 'of_id' [-Werror=unused-variable]

Fixes: abaca806fd13 ("IIO: ADC: stm32-dfsdm: code optimization")

Weird, "git show abaca806fd13" contains this exact hunk. I guess it's actually the subsequent merge commit at fault...

Robin.

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
drivers/iio/adc/stm32-dfsdm-core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c
index 84277bcc465f..6290332cfd3f 100644
--- a/drivers/iio/adc/stm32-dfsdm-core.c
+++ b/drivers/iio/adc/stm32-dfsdm-core.c
@@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match);
static int stm32_dfsdm_probe(struct platform_device *pdev)
{
struct dfsdm_priv *priv;
- const struct of_device_id *of_id;
const struct stm32_dfsdm_dev_data *dev_data;
struct stm32_dfsdm *dfsdm;
int ret;