Re: [PATCH -next] drm/etnaviv: make local symbols static

[Lucas Stach]

Am Donnerstag, den 11.01.2018, 11:34 +0000 schrieb Wei Yongjun:
> Fixes the following sparse warnings:
> 
> drivers/gpu/drm/etnaviv/etnaviv_iommu.c:161:39: warning:
> Âsymbol 'etnaviv_iommuv1_ops' was not declared. Should it be static?
> drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c:239:39: warning:
> Âsymbol 'etnaviv_iommuv2_ops' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>

Thanks, applied to etnaviv/next.

> ---
> Âdrivers/gpu/drm/etnaviv/etnaviv_iommu.c | 2 +-
> Âdrivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c | 2 +-
> Â2 file changed, 2 insertion(+), 2 deletion(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu.c
> b/drivers/gpu/drm/etnaviv/etnaviv_iommu.c
> index 7a8c947..4b9b11c 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_iommu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_iommu.c
> @@ -158,7 +158,7 @@ void etnaviv_iommuv1_restore(struct etnaviv_gpu
> *gpu)
> Â	gpu_write(gpu, VIVS_MC_MMU_RA_PAGE_TABLE, pgtable);
> Â}
> Â
> -const struct etnaviv_iommu_domain_ops etnaviv_iommuv1_ops = {
> +static const struct etnaviv_iommu_domain_ops etnaviv_iommuv1_ops = {
> Â	.free = etnaviv_iommuv1_domain_free,
> Â	.map = etnaviv_iommuv1_map,
> Â	.unmap = etnaviv_iommuv1_unmap,
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c
> b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c
> index 1e956e2..6e7c892 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c
> @@ -236,7 +236,7 @@ void etnaviv_iommuv2_restore(struct etnaviv_gpu
> *gpu)
> Â	gpu_write(gpu, VIVS_MMUv2_CONTROL,
> VIVS_MMUv2_CONTROL_ENABLE);
> Â}
> Â
> -const struct etnaviv_iommu_domain_ops etnaviv_iommuv2_ops = {
> +static const struct etnaviv_iommu_domain_ops etnaviv_iommuv2_ops = {
> Â	.free = etnaviv_iommuv2_domain_free,
> Â	.map = etnaviv_iommuv2_map,
> Â	.unmap = etnaviv_iommuv2_unmap,
>