Re: [net-next: PATCH v3 0/7] Armada 7k/8k PP2 ACPI support
From: Andrew Lunn
Date: Wed Jan 17 2018 - 13:12:06 EST
On Wed, Jan 17, 2018 at 05:55:39PM +0100, Marcin Wojtas wrote:
> Hi,
>
> This is a third version of the patchset introducing mvpp2 driver ability
> to operate with ACPI. Until follow-up generic MDIO is introduced
> it can using the link interrupt capability (a.k.a. in-band management)
> on all ports, 1000BaseT RGMII included.
> Driver operation was tested on top of the net-next branch
> with both DT and ACPI on MacchiatoBin and Armada 7040 DB boards.
>
> The main changes were requested during v2 review, which was
> adding generic helper routines for:
> * interating over available fwnodes (new patch 4/7)
> * getting IRQ directly from fwnode (new patch 3/7)
Hi Marcin
Thanks for adding these helpers. It makes the changes for ACPI much
less invasive and more natural.
Does the IRQ helper solve the issue of getting an interrupt from a
child node? I don't see this explicitly mentioned in the commit. It
seems to be getting it from a device. Is the child a device?
Thanks
Andrew