Re: [PATCH net-next] net: core: Expose number of link up/down transitions

[David Ahern]

On 1/17/18 3:52 PM, Jiri Pirko wrote:
> Thu, Jan 18, 2018 at 12:06:57AM CET, f.fainelli@xxxxxxxxx wrote:
>> From: David Decotigny <decot@xxxxxxxxxxxx>
>>
>> Expose the number of times the link has been going UP or DOWN, and
>> update the "carrier_changes" counter to be the sum of these two events.
>> While at it, also update the sysfs-class-net documentation to cover:
>> carrier_changes (3.15), count_link_up (4.16) and count_link_down (4.16)
>>
>> Signed-off-by: David Decotigny <decot@xxxxxxxxxxxx>
> 
> [...]
> 
> 
>> @@ -161,6 +161,8 @@ enum {
>> 	IFLA_EVENT,
>> 	IFLA_NEW_NETNSID,
>> 	IFLA_IF_NETNSID,
>> +	IFLA_COUNT_LINK_UP,
>> +	IFLA_COUNT_LINK_DOWN,
> 
> 
> 	IFLA_LINK_UP_COUNT,
> 	IFLA_LINK_DOWN_COUNT,
> 
> would sound a bit nicer to me.

given existing IFLA_LINK_* attributes how about
IFLA_CARRIER_{UP,DOWN}_COUNT?