Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC

[poza]

On 2018-01-18 10:47, poza@xxxxxxxxxxxxxx wrote:
> On 2018-01-17 22:16, Sinan Kaya wrote:
> > On 1/17/2018 5:37 AM, Oza Pawandeep wrote:
> > > +++ b/include/linux/dpc.h
> > > @@ -0,0 +1,9 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > +
> > > +#ifndef _DPC_H_
> > > +#define _DPC_H_
> > > +
> > > +#define DPC_FATAL		4
> > > +
> > > +#endif //_DPC_H_
> > > +
> >
> > can you keep this in drivers/pci.h and get rid of this file?
>
> I thought about this, but if I keep it in drivers/pci.h,
> then AER's defines have to be in that as well. (for unification)
>
> and then all the dependent files who are using AER_FATAL such as
> drivers/acpi/apei/ghees.c
> have to go on including this drivers file which is odd way of doing it.
>
> So I am not very sure about this....since AER_FATAL are in aer.h, I
> have made dpc.h
>
>
> Regards,
> Oza.

Should I be doing in next patch-set series ?