Re: [PATCH 3/3] pinctrl: sx150x: add a static gpio/pinctrl pin range mapping

From: Linus Walleij
Date: Thu Jan 18 2018 - 05:03:57 EST


On Thu, Jan 18, 2018 at 9:19 AM, Peter Rosin <peda@xxxxxxxxxx> wrote:
> On 2018-01-18 08:58, Linus Walleij wrote:
>> On Wed, Jan 17, 2018 at 2:34 PM, Peter Rosin <peda@xxxxxxxxxx> wrote:
>>
>>> Without such a range, gpiolib fails with -EPROBE_DEFER, pending the
>>> addition of the range. So, without a range, gpiolib will keep
>>> deferring indefinitely.
>>>
>>> Fixes: e10f72bf4b3e ("gpio: gpiolib: Generalise state persistence beyond sleep")
>>> Suggested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>
>>
>> Added the other Fixes: tag as well, add Cc: stable and applied.
>>
>> It will go in for the merge window as it is now, unless Torvalds
>> decide to do an -rc9 in which case I will consider sending it as
>> a separate fix next week.
>
> I didn't (yet?) receive any notification about patch 2/3 and thought
> I'd test what would happen without it, and results are not good.
> I get:
>
> gpio gpiochip5: (sx1502q): could not create pin range
>
> So, I guess if 3/3 is going to stable, all three patches should go
> there.

OK then I mark them all for stable.

Yours,
Linus Walleij