Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

[Emil Velikov]

On 17 January 2018 at 16:37, Daniel Thompson <daniel.thompson@xxxxxxxxxx> wrote:
>
>
> On 17/01/18 14:36, Emil Velikov wrote:
>>
>> On 17 January 2018 at 14:01, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
>>>
>>> Nothing in the entire tree ever sets this, which means this is dead
>>> code. Remove it.
>>>
>>> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
>>> Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
>>> Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
>>> Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
>>> ---
>>>   drivers/video/backlight/generic_bl.c | 5 -----
>>
>>
>> Fly-by comment, while waiting for coffee to kick-in.
>> I think this patch should be after pandora/others have stopped abusing
>> BL_CORE_DRIVER1.
>
>
> You sure?
>
> I can't see why the use or disuse of BL_CORE_DRIVER1 in this driver should
> influence another independent driver.
>
Right my bad. Got mislead by the driver name.

-Emil