Re: [PATCH] [net-next] net: sched: avoid uninitialized variable use

[Jiri Pirko]

Thu, Jan 18, 2018 at 02:17:28PM CET, arnd@xxxxxxxx wrote:
>gcc has identified a code path in which we pass uninitialized
>data into tc_dump_tfilter():
>
>net/sched/cls_api.c: In function 'tc_dump_tfilter':
>net/sched/cls_api.c:1268:8: error: 'parent' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
>This initializes the variable to the value it had before the previous
>change.
>
>Fixes: 7960d1daf278 ("net: sched: use block index as a handle instead of qdisc when block is shared")
>Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>----
>I don't know if my patch is the best way to address the issue, but
>if not, then at least it helps show what the warning is about
>and lets someone else come up with a better solution.

I already sent a fix for this:
http://patchwork.ozlabs.org/patch/862787/