Re: [PATCH v1 tip/master 0/3] kprobes/x86: retpoline: Fix kprobes for retpoline

[Masami Hiramatsu]

On Thu, 18 Jan 2018 05:01:57 -0800
Andi Kleen <ak@xxxxxxxxxxxxxxx> wrote:

> > Side effect: [1/3] will move __x86_indirect_thunk_* functions
> > in kernel text area. Of course those functions were in the
> > .text area, but placed in right after _etext. This just moves
> > it right before the _etext.
> 
> I assume you tested that with page table isolation on?
> 
> The thunks need to be accessible from the trampoline.

Yes, I've tested the kernel with CONFIG_PAGE_TABLE_ISOLATION=y.
As David pointed, maybe all those points are using JMP/CALL_NOSPEC macro directly?

Thanks,

> 
> -Andi


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>