Re: [PATCH] Support tablet mode switch for Dell laptops

[Pali RohÃr]

On Thursday 18 January 2018 14:59:50 Marco Martin wrote:
> -	if (!sparse_keymap_report_event(priv->input_dev, event, 1, true))
> +	if (event == 0xCC) {
> +		input_report_switch(priv->input_dev, SW_TABLET_MODE, 1);
> +		input_sync(priv->input_dev);
> +	} else if (event == 0xCD) {
> +		input_report_switch(priv->input_dev, SW_TABLET_MODE, 0);
> +		input_sync(priv->input_dev);
> +	} else if (!sparse_keymap_report_event(priv->input_dev, event, 1, true))

Is not it possible to put 0xCC and 0xCD into sparse keymap table?
Because IIRC sparse keymap was created just to avoid that big
if-elseif-elseif-else blocks.

>  		dev_info(&device->dev, "unknown event index 0x%x\n",
>  			 event);
>  }

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx