Re: [PATCH 2/3] arm64: dts: rockchip: add USB3 OTG reset for Type-C PHY on rk3399

From: Enric Balletbo Serra
Date: Thu Jan 18 2018 - 12:22:08 EST


2018-01-12 11:08 GMT+01:00 William Wu <william.wu@xxxxxxxxxxxxxx>:
> Add USB3 OTG reset for Type-C PHY. It can be used to hold the USB3
> OTG controller in reset state before initializing the Type-C PHY.
>
> Signed-off-by: William Wu <william.wu@xxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index d340b58a..4e89d00 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1377,8 +1377,9 @@
> power-domains = <&power RK3399_PD_TCPD0>;
> resets = <&cru SRST_UPHY0>,
> <&cru SRST_UPHY0_PIPE_L00>,
> - <&cru SRST_P_UPHY0_TCPHY>;
> - reset-names = "uphy", "uphy-pipe", "uphy-tcphy";
> + <&cru SRST_P_UPHY0_TCPHY>,
> + <&cru SRST_A_USB3_OTG0>;
> + reset-names = "uphy", "uphy-pipe", "uphy-tcphy", "usb3-otg";
> rockchip,grf = <&grf>;
> rockchip,typec-conn-dir = <0xe580 0 16>;
> rockchip,usb3tousb2-en = <0xe580 3 19>;
> @@ -1406,8 +1407,9 @@
> power-domains = <&power RK3399_PD_TCPD1>;
> resets = <&cru SRST_UPHY1>,
> <&cru SRST_UPHY1_PIPE_L00>,
> - <&cru SRST_P_UPHY1_TCPHY>;
> - reset-names = "uphy", "uphy-pipe", "uphy-tcphy";
> + <&cru SRST_P_UPHY1_TCPHY>,
> + <&cru SRST_A_USB3_OTG1>;
> + reset-names = "uphy", "uphy-pipe", "uphy-tcphy", "usb3-otg";
> rockchip,grf = <&grf>;
> rockchip,typec-conn-dir = <0xe58c 0 16>;
> rockchip,usb3tousb2-en = <0xe58c 3 19>;
> --
> 2.0.0
>
>

Tested-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>