Re: [PATCH] PCI: dwc: dra7xx: add back CONFIG_PCI dependency for endpoint

[Lorenzo Pieralisi]

On Thu, Jan 18, 2018 at 05:39:02PM +0100, Arnd Bergmann wrote:

[...]

> > However, since pci_irqd_intx_xlate is only defined inside
> > CONFIG_PCI, even 489f8fe6aa71 will not help.
> >
> > Not completely sure about this, but perhaps a better fix is:
> >
> > +++ b/include/linux/pci.h
> > @@ -1686,6 +1686,12 @@ static inline int pci_get_new_domain_nr(void) { return -ENOSYS; }
> >  #define dev_is_pf(d) (false)
> >  static inline bool pci_acs_enabled(struct pci_dev *pdev, u16 acs_flags)
> >  { return false; }
> > +static inline int pci_irqd_intx_xlate(struct irq_domain *d,
> > +                                     struct device_node *node,
> > +                                     const u32 *intspec,
> > +                                     unsigned int intsize,
> > +                                     unsigned long *out_hwirq,
> > +                                     unsigned int *out_type) { return 0; }
> >  #endif /* CONFIG_PCI */
> >
> >  /* Include architecture-dependent settings and functions */
> >
> >
> > And a 'Fixes:' tag that references 524d59f6e30a
> 
> Looks fine to me, but I'd put the '{ return 0; }' in a new line for consistency
> with the other functions here, and maybe return -EINVAL instead of
> zero.
> 
> Can you submit that as a proper patch and add my
> 
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

You can add my:

Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>

too but I am a bit dubious about the Fixes: tag (it will be merged via
a separate branch and I do not think we really need it), I would omit it.

Please send it as soon as possible or I can do it, please let me
know.

Thanks,
Lorenzo