Re: [PATCH-next] init/main.c: make local symbol static

[Randy Dunlap]

On 01/18/2018 03:33 PM, Christopher DÃaz Riveros wrote:
> El jue, 18-01-2018 a las 16:31 -0600, Tom Lendacky escribiÃ:
>> On 1/18/2018 4:09 PM, Randy Dunlap wrote:
>>> On 01/18/2018 02:06 PM, Christopher DÃaz Riveros wrote:
>>>> Fixes the following sparse warning:
>>>>
>>>> init/main.c:167:12: warning:
>>>>   symbol 'envp_init' was not declared. Should it be static?
>>>>
>>>> Signed-off-by: Christopher DÃaz Riveros <chrisadr@xxxxxxxxxx>
>>>
>>> Does the kernel build OK after this change?
>>>
> 
> I built it a couple of times before sending the patch, now I compiled
> it again and everything went ok.
> 
>>> What about the other user(s) of envp_init?
>>
>> It looks like it's referenced in init/do_mounts_initrd.c.  Rather
>> than making it static, it should be declared in .h file.
>>

init/Makefile should give you a clue.

> 
> Ok, I'll try to figure it out, akpm accepted the patch in mm-next but
> was dropped because of testing failures. I'm still very new to all of
> this process.


-- 
~Randy