Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC

[poza]

On 2018-01-18 23:33, Sinan Kaya wrote:
> On 1/18/2018 1:00 PM, poza@xxxxxxxxxxxxxx wrote:
> > > I think you would put into include/linux/pci.h only if there is an 
> > > external
> > > use of constant outside of drivers/pci directory. Otherwise, you 
> > > should keep
> > > the setting inside one of the header files in drivers/pci directory.
> > >
> > > I don't see any other subsystem caring about DPC_FATAL definition.
> >
> > ok so you are suggesting to move only DPC_FATAL ? so then AER can stay 
> > where it is.
>
> Now that both AER and DPC handling is getting unified, I think it makes 
> sense to
> keep all error codes (AER+DPC) together in drivers/pci/pci.h rather 
> than having
> them split in aer.h and dpc.h.
>
> Otherwise, how would we avoid having a new error type defined with the
> existing values.

I agree, its is just that drivers/acpi/apet/ghes.c has to do
#include ../../pci/pci.h

but thats okay I think.  let me move error codes to drivers/pci/pci.h.

Regards,
Oza.