Re: [PATCH v5 29/44] ARM: da8xx: add new USB PHY clock init using common clock framework

[Sekhar Nori]

On Friday 19 January 2018 12:13 AM, David Lechner wrote:
> On 01/18/2018 09:14 AM, Sekhar Nori wrote:
>> On Monday 08 January 2018 07:47 AM, David Lechner wrote:
>>> +int __init da8xx_register_usb20_phy_clk(bool use_usb_refclkin)
>>> +{
>>> +ÂÂÂ struct regmap *cfgchip;
>>> +ÂÂÂ struct clk *usb0_psc_clk, *clk;
>>> +ÂÂÂ struct clk_hw *parent;
>>> +
>>> +ÂÂÂ cfgchip = syscon_regmap_lookup_by_compatible("ti,da830-cfgchip");
>>
>> Am I right in understanding that this API is only called for non-DT
>> boot? If yes, do we really need the lookup by compatible?
> 
> This code is used in DT boot until [PATCH v5 43/44] "ARM: da8xx-dt:
> switch to device tree clocks". So, yes it is needed temporarily to
> prevent breaking USB.

Alright, so this line should probably be dropped either as part of 43/44
or later.

Thanks,
Sekhar