Re: [PATCH] smc: return boolean instead of integer in using_ipsec

[Gustavo A. R. Silva]

Hi Ursula,

Quoting Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx>:

> On 01/19/2018 12:33 AM, Gustavo A. R. Silva wrote:
> > Return statements in functions returning bool should use
> > true/false instead of 1/0.
> >
> > This issue was detected with the help of Coccinelle.
> >
> > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> > ---
> >  net/smc/smc.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/smc/smc.h b/net/smc/smc.h
> > index 0bee9d1..ef13af4 100644
> > --- a/net/smc/smc.h
> > +++ b/net/smc/smc.h
> > @@ -258,7 +258,7 @@ static inline bool using_ipsec(struct smc_sock *smc)
> >  #else
> >  static inline bool using_ipsec(struct smc_sock *smc)
> >  {
> > -	return 0;
> > +	return false;
> >  }
> >  #endif
>
> Gustavo,
> thanks for reporting, but your improvement seems to be incomplete.  
> Besides changing
> line 260 of net/smc/smc.h, line 255 should be adapted the same way. Will you
> come up with a second patch version here?

You are correct. I'll send a new patch shortly.

Thanks for the feedback.
--
Gustavo