Re: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

From: JeffyChen
Date: Sun Jan 21 2018 - 23:10:05 EST


Hi Randy,

On 01/22/2018 10:15 AM, JeffyChen wrote:
Hi Randy,

On 01/22/2018 09:18 AM, Randy Li wrote:

Also the power domain driver could manage the clocks as well, I would
suggest to use pm_runtime_*.

actually the clocks required by pm domain may not be the same as what we
want to control here, there might be some clocks only be needed when
accessing mmu registers.

but i'm not very sure about that, will confirm it with Simon Xue.

confirmed with Simon, there might be some iommus don't have a pd, and the CONFIG_PM could be disabled.

so it might be better to control clocks in iommu driver itself.