Re: [PATCH 4.14 16/89] futex: Avoid violating the 10th rule of futex

[Geert Uytterhoeven]

Hi Greg,

On Mon, Jan 22, 2018 at 10:53 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Jan 22, 2018 at 10:48:55AM +0100, Geert Uytterhoeven wrote:
>> On Mon, Jan 22, 2018 at 9:44 AM, Greg Kroah-Hartman
>> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> > 4.14-stable review patch.  If anyone has any objections, please let me know.
>> >
>> > ------------------
>> >
>> > From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>> >
>> > commit c1e2f0eaf015fb7076d51a339011f2383e6dd389 upstream.
>>
>> May be a bit premature, given the fishy use of newtid, cfr. my comment
>> in https://lkml.org/lkml/2018/1/22/274
>
> Not really a bug, but I will be glad to take any future patches that end
> up in Linus's tree to resolve your issue with obsolete compilers like
> this :)

I'm not worried about the old compiler.
I'm worried about a real bug related to the no longer used assignment.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds