Re: [PATCH 2/2] usb: dwc3: drd: Fix lock-up on ID change during system suspend/resume

From: Roger Quadros
Date: Tue Jan 23 2018 - 07:41:34 EST


Hi Manu,

On 23/01/18 05:45, Manu Gautam wrote:
> Hi,
>
>
> On 1/22/2018 6:31 PM, Roger Quadros wrote:
>> Adding/removing host/gadget controller before .pm_complete()
>> causes a lock-up. Let's prevent any dual-role state change
>> between .pm_prepare() and .pm_complete() to fix this.
>
> What kind of lock-up are you seeing? Some hardware lockup or software deadlock?
> IMO using a freezable_wq for drd_work should address that?
>

I was seeing a software deadlock. freezable_wq is a good idea. I'll try it out.

>
>>
<snip>

--
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki