Re: [PATCH] net: ipv6: ndisc: fix bool assignment in ndisc_send_na

From: Gustavo A. R. Silva
Date: Tue Jan 23 2018 - 10:21:19 EST



Quoting David Miller <davem@xxxxxxxxxxxxx>:

From: "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx>
Date: Mon, 22 Jan 2018 16:22:13 -0600

Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle.

Fixes: 1cb3fe513f62 ("ndisc: Break down ndisc_build_skb() and build message directly.")
Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

Please don't use the word "fix".

'0' is the same as 'false', it's just that the latter is more
consistent type wise.


So "Use true and false for boolean value" would be a better subject?

Thanks
--
Gustavo