Re: [PATCH 14/14] MIPS: memblock: Deactivate bootmem allocator

From: James Hogan
Date: Tue Jan 23 2018 - 19:00:08 EST


On Thu, Jan 18, 2018 at 01:23:12AM +0300, Serge Semin wrote:
> Memblock allocator can be successfully used from now for early
> memory management
>
> Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx>

Am I correct that intermediate commits in this patchset (i.e. bisection)
may not work correctly, since bootmem will have been stripped out but
NO_BOOTMEM=n and memblock may not be properly operational yet?

If so, is there a way to switch without breaking bisection that doesn't
involve squashing most of the series into a single atomic commit?

Cheers
James

> ---
> arch/mips/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 725b5ece7..a6c4fb6b6 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -4,7 +4,6 @@ config MIPS
> default y
> select ARCH_BINFMT_ELF_STATE
> select ARCH_CLOCKSOURCE_DATA
> - select ARCH_DISCARD_MEMBLOCK
> select ARCH_HAS_ELF_RANDOMIZE
> select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
> select ARCH_MIGHT_HAVE_PC_PARPORT
> @@ -57,6 +57,7 @@ config MIPS
> select HAVE_IRQ_TIME_ACCOUNTING
> select HAVE_KPROBES
> select HAVE_KRETPROBES
> + select NO_BOOTMEM
> select HAVE_MEMBLOCK
> select HAVE_MEMBLOCK_NODE_MAP
> select HAVE_MOD_ARCH_SPECIFIC
> --
> 2.12.0
>

Attachment: signature.asc
Description: Digital signature