Re: [PATCH] drivers/macintosh: Use true for boolean value

[Gustavo A. R. Silva]

Quoting "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx>:

> Quoting Michael Ellerman <mpe@xxxxxxxxxxxxxx>:
>
> > "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx> writes:
> >
> > > Assign true or false to boolean variables instead of an integer value.
> > >
> > > This issue was detected with the help of Coccinelle.
> > >
> > > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > > ---
> > > drivers/macintosh/windfarm_pm72.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > This seems to be common across all those drivers. Can you please send
> > one patch to fix them all to use bool:
> >
> >  $ git grep "started = " drivers/macintosh/
> >  drivers/macintosh/therm_adt746x.c:              int started = 0;
> >  drivers/macintosh/therm_adt746x.c:                      started = 1;
> >  drivers/macintosh/windfarm_pm112.c:             slots_started = 1;
> >  drivers/macintosh/windfarm_pm112.c:             started = 1;
> >  drivers/macintosh/windfarm_pm121.c:             pm121_started = 1;
> >  drivers/macintosh/windfarm_pm72.c:              started = 1;
> >  drivers/macintosh/windfarm_pm81.c:              wf_smu_started = 1;
> >  drivers/macintosh/windfarm_pm91.c:              wf_smu_started = 1;
> >  drivers/macintosh/windfarm_rm31.c:              started = 1;
> >
> > cheers
>
> Sure, no problem.
>
> By the way, I've just found the following similar case:
>
> --- a/drivers/macintosh/ams/ams-input.c
> +++ b/drivers/macintosh/ams/ams-input.c
> @@ -91,7 +91,7 @@ static int ams_input_enable(void)
>  		return error;
>  	}
>
> -	joystick = 1;
> +	joystick = true;
>
>  	return 0;
>  }
> @@ -104,7 +104,7 @@ static void ams_input_disable(void)
>  		ams_info.idev = NULL;
>  	}
>
> -	joystick = 0;
> +	joystick = false;
>  }
>
> Do you want me to include them all in the same patch?

I sent separate patches for this.

Thanks
--
Gustavo