Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

[walter harms]

Am 23.01.2018 21:10, schrieb Christopher DÃaz Riveros:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Christopher DÃaz Riveros <chrisadr@xxxxxxxxxx>
> ---
>  drivers/misc/mic/scif/scif_epd.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/mic/scif/scif_epd.h b/drivers/misc/mic/scif/scif_epd.h
> index f39b663da287..b2a835665390 100644
> --- a/drivers/misc/mic/scif/scif_epd.h
> +++ b/drivers/misc/mic/scif/scif_epd.h
> @@ -165,9 +165,7 @@ static inline int scif_verify_epd(struct scif_endpt *ep)
>  static inline int scif_anon_inode_getfile(scif_epd_t epd)
>  {
>  	epd->anon = anon_inode_getfile("scif", &scif_anon_fops, NULL, 0);
> -	if (IS_ERR(epd->anon))
> -		return PTR_ERR(epd->anon);
> -	return 0;
> +	return PTR_ERR_OR_ZERO(epd->anon);
>  }
>  

the patch looks ok,
but someone should thing about if it makes sense to have a oneliner as function.
IMHO this will only confuse readers (note: yes, there are reasons in some cases,
but i do not see what applies here if any).

re,
 wh

>  static inline void scif_anon_inode_fput(scif_epd_t epd)