Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe()

From: Jamie Iles
Date: Wed Jan 24 2018 - 08:08:35 EST


Thanks Alexey!

On Sat, Jan 20, 2018 at 12:53:15AM +0300, Alexey Khoroshilov wrote:
> If clk_get() fails, device_remove_file() looks inappropriate.
>
> The error path, where all crypto_register fail, misses resource
> deallocations.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>

Reviewed-by: Jamie Iles <jamie@xxxxxxxxxxxxx>