Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

[Sinan Kaya]

On 1/24/2018 11:09 AM, Hans de Goede wrote:
>>>> There must be a middle ground somewhere.
>>>
>>> One thing which comes to mind is to simply not allow building i2c as a module
>>> when ACPI is selected, something like this should work I think:
>>>
>>> ÂÂconfig I2C
>>> ÂÂÂÂÂÂÂÂÂ tristate "I2C support"
>>> ÂÂÂÂÂÂÂÂÂ select RT_MUTEXES
>>> ÂÂÂÂÂÂÂÂÂ select IRQ_DOMAIN
>>> +ÂÂÂÂÂÂÂ # force building I2C in on ACPI systems, for opregion availability
>>> +ÂÂÂÂÂÂÂ depends on y || !ACPI
>>
>> This works for me.
> 
> OK, so feel free to turn it into a proper patch and submit it
> upstream.

OK. Let me do some build tests.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.