Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read_file()

From: Mark Brown
Date: Wed Jan 24 2018 - 12:05:08 EST


On Wed, Jan 24, 2018 at 10:27:22AM -0600, David Lechner wrote:
> On 01/24/2018 10:19 AM, Mark Brown wrote:

> > Indeed. It is an improvement but not exactly helpful.

> Would it be better if it said "this regmap does not have driver" instead
> of "(null)"?

That's both not idiomatically good and isn't even true... ideally we'd
be able to get some sort of string out of the user, but otherwise
"nodev" or perhaps printing the pointer to the regmap (to avoid
collisions if there's more than one of these in a system).

Attachment: signature.asc
Description: PGP signature