Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

[Wang, Haiyue]

On 2018-01-23 16:44, Greg KH wrote:
> On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote:
> > When PCH works under eSPI mode, the PMC (Power Management Controller) in
> > PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It is in
> > dead loop if no SUS_ACK assert. This is the basic requirement for the BMC
> > works as eSPI slave.
> >
> > Also for the host power on / off actions, from BMC side, the following VW
> > (Virtual Wire) messages are done in firmware:
> > 1. SLAVE_BOOT_LOAD_DONE / SLAVE_BOOT_LOAD_STATUS
> > 2. SUS_ACK
> > 3. OOB_RESET_ACK
> > 4. HOST_RESET_ACK
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@xxxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/misc/aspeed-espi-slave.txt |  20 ++
> >   Documentation/misc-devices/espi-slave.rst          | 114 +++++++++
> DT files need to be split out into a separate patch so that the DT
> maintainers can properly review them.
>
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -471,6 +471,17 @@ config VEXPRESS_SYSCFG
> >   	  ARM Ltd. Versatile Express uses specialised platform configuration
> >   	  bus. System Configuration interface is one of the possible means
> >   	  of generating transactions on this bus.
> > +config ASPEED_ESPI_SLAVE
> You need a blank line above this one please.
Fixed.
> > +	depends on ARCH_ASPEED || COMPILE_TEST
> > +	select REGMAP_MMIO
> Select or depend?
Before, I used "depends on". I was told to to change "select". I'm not 
sure which is more better by practice ?
> > +	tristate "Aspeed ast2500 eSPI slave device"
> > +	---help---
> > +	  This allows host to access Baseboard Management Controller (BMC) over the
> > +	  Enhanced Serial Peripheral Interface (eSPI) bus, which replaces the Low Pin
> > +	  Count (LPC) bus.
> > +
> > +	  Its interface supports peripheral, virtual wire, out-of-band, and flash
> > +	  sharing channels.
> What is the module name?
You means the --help-- description is not clear and specific ?
> >   
> >   config ASPEED_LPC_CTRL
> >   	depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON
> > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> > index 5ca5f64..a1081f4 100644
> > --- a/drivers/misc/Makefile
> > +++ b/drivers/misc/Makefile
> > @@ -52,6 +52,7 @@ obj-$(CONFIG_GENWQE)		+= genwqe/
> >   obj-$(CONFIG_ECHO)		+= echo/
> >   obj-$(CONFIG_VEXPRESS_SYSCFG)	+= vexpress-syscfg.o
> >   obj-$(CONFIG_CXL_BASE)		+= cxl/
> > +obj-$(CONFIG_ASPEED_ESPI_SLAVE) += aspeed-espi-slave.o
> Why no tab?
Fixed, thanks.
> thanks,
>
> greg k-h