Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

[Thomas Gleixner]

On Thu, 25 Jan 2018, Jiri Slaby wrote:
> On 01/22/2018, 09:44 AM, Greg Kroah-Hartman wrote:
> > +	if (nr_wake < 0 || nr_requeue < 0)
> > +		return -EINVAL;
> 
> This breaks strace's test suite on 4.14.15 (and is present in upstream
> obviously too):
>     futex(0x7ff568b44ffc, 0x3, 0xfacefeed, 0xbadda7a0ca7b100d,
> 0x7ff568b44ffc, 0x9caffee1) = -1: Invalid argument

And why the hell is strace expecting this to be valid?

Thanks,

	tglx