Re: [RESEND PATCH 1/6] crypto: caam: Fix null dereference at error path

From: Horia Geantă
Date: Thu Jan 25 2018 - 12:09:54 EST


On 1/24/2018 4:50 PM, Bryan O'Donoghue wrote:
> From: Rui Miguel Silva <rui.silva@xxxxxxxxxx>
>
> caam_remove already removes the debugfs entry, so we need to remove the one
> immediately before calling caam_remove.
>
> This fix a NULL dereference at error paths is caam_probe fail.
>
> [bod: changed name prefix to "crypto: caam: Fix .."]
> [bod: added Fixes tag]
>
> Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend
> support")
Cc: <stable@xxxxxxxxxxxxxxx> # 4.12+

>
> Tested-by: Ryan Harkin <ryan.harkin@xxxxxxxxxx>
> Signed-off-by: Rui Miguel Silva <rui.silva@xxxxxxxxxx>
> Cc: "Horia Geantă" <horia.geanta@xxxxxxx>
> Cc: Aymen Sghaier <aymen.sghaier@xxxxxxx>
> Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> Cc: Peng Fan <peng.fan@xxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Lukas Auer <lukas.auer@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Bryan O'Donoghue <pure.logic@xxxxxxxxxxxxxxxxx>
Reviewed-by: Horia Geantă <horia.geanta@xxxxxxx>

Thanks,
Horia