Re: [PATCH RFC 4/4] drivers: irqchip: qcom: add pin information for SDM845

[Lina Iyer]

On Wed, Jan 24 2018 at 14:20 +0000, Marc Zyngier wrote:
> On 23/01/18 17:56, Lina Iyer wrote:
> > From: Archana Sathyakumar <asathyak@xxxxxxxxxxxxxx>
> >
> > +#include "qcom-pdc.h"
> > +
> > +const struct pdc_pin sdm845_data[] = {
> > +	{0, 512}, /* rpmh_wake */
> > +	{1, 513}, /* ee0_apps_hlos_spmi_periph_irq */
> > +	{2, 514}, /* ee1_apps_trustzone_spmi_periph_irq */
> > +	{3, 515}, /* secure_wdog_expired */
> > +	{4, 516}, /* secure_wdog_bark_irq */
> > +	{5, 517}, /* aop_wdog_expired_irq */
> > +	{6, 518}, /* qmp_usb3_lfps_rxterm_irq */
>
> [...]
>
> Nice try, but no. This is DT material. Please use the pin number in your
> DT, which the driver uses as a hwirq. When it comes to mapping it to the
> corresponding GIC SPI, use a per-soc helper that comes from DT too (you
> seem to only have two ranges here, so that's pretty easy to do).
Thanks Marc. I will look into this approach.

-- Lina