Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

From: David Woodhouse
Date: Fri Jan 26 2018 - 04:57:25 EST


On Thu, 2018-01-25 at 12:35 +0100, Peter Zijlstra wrote:
> On Thu, Jan 25, 2018 at 10:52:53AM +0000, David Woodhouse wrote:
> >
> > OK, my brain hurts a bit but I'm happy now. Thank you.
> OK, I've updated the Changelog thusly. Is this satisfactory?
>
> ---
> Subject: x86/paravirt: Annotate indirect calls
> From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Date: Wed Jan 17 16:58:11 CET 2018
>
> Paravirt emits indirect calls which get flagged by objtool retpoline
> checks, annotate it away because all these indirect calls will be
> patched out before we start userspace.
>
> This patching happens through alternative_instructions() ->
> apply_paravirt() -> pv_init_ops.patch() which will eventually end up
> in paravirt_patch_default(). This function _will_ write direct
> alternatives.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>

Reviewed-by: David Woodhouse <dwmw@xxxxxxxxxxxx>

I love you, Peter.

Attachment: smime.p7s
Description: S/MIME cryptographic signature