Re: [PATCH 05/24] x86: Annotate indirect jump in head_64.S

[David Woodhouse]

On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote:
> The objtool retpoline validation found this indirect jump. Seeing how
> its on CPU bringup before we run userspace it should be safe, annotate

http://angryflower.com/itsits.gif

> it.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>

Reviewed-by: David Woodhouse <dwmw@xxxxxxxxxxxx>


> ---
> Âarch/x86/kernel/head_64.S |ÂÂÂÂ2 ++
> Â1 file changed, 2 insertions(+)
> 
> --- a/arch/x86/kernel/head_64.S
> +++ b/arch/x86/kernel/head_64.S
> @@ -23,6 +23,7 @@
> Â#include 
> Â#include "../entry/calling.h"
> Â#include 
> +#include 
> Â
> Â#ifdef CONFIG_PARAVIRT
> Â#include 
> @@ -134,6 +135,7 @@ ENTRY(secondary_startup_64)
> Â
> Â	/* Ensure I am executing from virtual addresses */
> Â	movq	$1f, %rax
> +	ANNOTATE_RETPOLINE_SAFE
> Â	jmp	*%rax
> Â1:
> Â	UNWIND_HINT_EMPTY
> 
>

Attachment: smime.p7s
Description: S/MIME cryptographic signature