Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

From: David Woodhouse
Date: Fri Jan 26 2018 - 13:45:27 EST


On Fri, 2018-01-26 at 19:41 +0100, Borislav Petkov wrote:
> +#define X86_FEATURE_AMD_IBPBÂÂÂÂÂÂÂÂÂÂÂ(13*32+12) /* "" Indirect Branch Prediction Barrier MSR */

Stray quotes.

> +#define X86_FEATURE_IBRSÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ(13*32+14) /* Indirect Branch Restricted Speculation */

Please don't call it that. Call it X86_FEATURE_AMD_IBRS and leave
X86_FEATURE_IBRS to parallel X86_FEATURE_IBPB as the *software* bit
which is vendor-independent.

Attachment: smime.p7s
Description: S/MIME cryptographic signature