Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

From: Fabio Estevam
Date: Fri Jan 26 2018 - 19:28:50 EST


On Fri, Jan 26, 2018 at 10:07 PM, BenoÃt ThÃbaudeau
<benoit.thebaudeau.dev@xxxxxxxxx> wrote:
> The eSDHC does not work properly if the SION bit is not set for the
> bidirectional CMD signal, whatever the eSDHC instance and the selected
> pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do
> this for MX25_PAD_*__SD*_CMD in imx25-pinfunc.h in order to enforce this
> behavior for all boards.
>
> This had already been done for eSDHC1, but not for eSDHC2. Also, define
> MX25_PAD_FEC_MDC__SDHC2_CMD so that all the possible cases are covered
> from now on.
>
> Signed-off-by: BenoÃt ThÃbaudeau <benoit.thebaudeau.dev@xxxxxxxxx>

Thanks for the fix:

Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx>