Re: [PATCH v2] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

[Andy Shevchenko]

On Sun, Jan 28, 2018 at 4:45 PM, Pali RohÃr <pali.rohar@xxxxxxxxx> wrote:
> On Sunday 28 January 2018 16:39:25 Andy Shevchenko wrote:
>> On Sat, Jan 27, 2018 at 3:32 PM, Pali RohÃr <pali.rohar@xxxxxxxxx> wrote:
>> > +static bool is_dell_system_with_lis3lv02d(void)
>> > +{
>>
>> > +       /*
>> > +        * Check that ACPI device SMO88xx exists and is enabled. That ACPI
>> > +        * device represent our ST microelectronics lis3lv02d accelerometer but
>> > +        * unfortunately without any other information (like i2c address).
>> > +        */
>>
>> Isn't it simple
>>
>> return acpi_dev_present("SMO88", NULL, -1);
>>
>> call?
>
> ACPI device name is SMO8800, SMO8810, ... Will that acpi_dev_present
> function match only prefix and not exact string?

OK, fair enough.

Do we have more users of such pattern? If so, it might make sense to
introduce a generic helper for that which takes a list of HIDs on
input.

(Yes, I do not like matching pattern like "XYZhh*", I prefer explicit
list of HIDs. Rationale to do so: a) any new potential collision is
excluded, b) we can easily grep kernel for a users per HID)

-- 
With Best Regards,
Andy Shevchenko