Re: [PATCH v2 13/19] drm/sun4i: backend: Set a default zpos in our reset hook

[Chen-Yu Tsai]

On Mon, Jan 22, 2018 at 6:35 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> The our plane state zpos value will be set only if there's an existing

      ^^^ extra word

Otherwise,

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>

> state attached to the plane when creating the property.
>
> However, this is not the case during the probe, and we therefore need to
> put our default value in our reset hook.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/sun4i/sun4i_layer.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c
> index c448cb6b9fa9..03549646528a 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_layer.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c
> @@ -28,6 +28,7 @@ struct sun4i_plane_desc {
>
>  static void sun4i_backend_layer_reset(struct drm_plane *plane)
>  {
> +       struct sun4i_layer *layer = plane_to_sun4i_layer(plane);
>         struct sun4i_layer_state *state;
>
>         if (plane->state) {
> @@ -43,6 +44,7 @@ static void sun4i_backend_layer_reset(struct drm_plane *plane)
>         if (state) {
>                 plane->state = &state->state;
>                 plane->state->plane = plane;
> +               plane->state->zpos = layer->id;
>         }
>  }
>
> --
> git-series 0.9.1